From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 10 Jun 2014 14:55:58 GMT
Subject: Re: [PATCH] git-submodule.sh: avoid "test <cond> -a/-o <cond>"
Message-ID: <xmqq7g4obypt.fsf@gitster.dls.corp.google.com>
In-Reply-To: <1402403313-22468-1-git-send-email-gitter.spiros@gmail.com>

Elia Pinto <gitter.spiros@gmail.com> writes:

> @@ -832,7 +832,7 @@ Maybe you want to use 'update --init'?")"
>  			continue
>  		fi
>  
> -		if ! test -d "$sm_path"/.git -o -f "$sm_path"/.git
> +		if ! test -d "$sm_path"/.git || test -f "$sm_path"/.git

Which part of test conditions does that "!" apply in the original,
and in the updated? 

I think the new test after || also needs negation, no?