From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 10 Nov 2014 22:43:10 GMT
Subject: Re: [PATCH] run-command: use void to declare that functions take no parameters
Message-ID: <xmqq7fz28yo1.fsf@gitster.dls.corp.google.com>
In-Reply-To: <54612B4C.8010609@web.de>

René Scharfe <l.s.r@web.de> writes:

> Explicitly declare that git_atexit_dispatch() and git_atexit_clear()
> take no parameters instead of leaving their parameter list empty and
> thus unspecified.
>
> Signed-off-by: Rene Scharfe <l.s.r@web.de>
> ---

Thanks.

I was kind of surprised after running a git blame to find that this
is a recent thing, and the same patch looked quite substandard with
numerious style violations, and I somehow managed to let them slip
in X-<.  Perhaps I was having a bad day or something...

>  run-command.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/run-command.c b/run-command.c
> index 79a0a76..a476999 100644
> --- a/run-command.c
> +++ b/run-command.c
> @@ -636,7 +636,7 @@ static struct {
>  
>  static int git_atexit_installed;
>  
> -static void git_atexit_dispatch()
> +static void git_atexit_dispatch(void)
>  {
>  	size_t i;
>  
> @@ -644,7 +644,7 @@ static void git_atexit_dispatch()
>  		git_atexit_hdlrs.handlers[i-1]();
>  }
>  
> -static void git_atexit_clear()
> +static void git_atexit_clear(void)
>  {
>  	free(git_atexit_hdlrs.handlers);
>  	memset(&git_atexit_hdlrs, 0, sizeof(git_atexit_hdlrs));