From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 30 Jun 2015 19:43:11 GMT
Subject: Re: [PATCH v7 07/10] send-email: reduce dependencies impact on parse_address_line
Message-ID: <xmqq7fqlc78w.fsf@gitster.dls.corp.google.com>
In-Reply-To: <vpqoajx2dka.fsf@anie.imag.fr>

Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:

> Junio C Hamano <gitster@pobox.com> writes:
>
>> Matthieu Moy <Matthieu.Moy@imag.fr> writes:
>>
>>> diff --git a/t/t9000-addresses.sh b/t/t9000-addresses.sh
>>> new file mode 100755
>>> index 0000000..7223d03
>>> --- /dev/null
>>> +++ b/t/t9000-addresses.sh
>>> @@ -0,0 +1,30 @@
>>> +#!/bin/sh
>>> +#
>>> +# Copyright (c) 2015
>>
>> That does not look like a valid copyright notice.
>>
>> In the modern age, I'd personally perfer not to add one
>
> I'd vote for keeping it simple and not having the copyright notice. Most
> t/*.sh do not have one. The Git history + mailing-list archives are much
> better than in-code comments to keep track of who wrote what.
>
> Remi: any objection on removing it?
>
> Junio: do you want me to resend?

It would be simpler to amend in-place either way.  Just let me know
if we want to drop it or add a name (and if the latter, what name).

Thanks.