From: Junio C Hamano Date: Wed, 29 Jul 2015 20:31:26 GMT Subject: Re: [PATCH] parse-options: align curly braces for all options Message-ID: In-Reply-To: <1438201117-11543-1-git-send-email-sbeller@google.com> Stefan Beller writes: > Signed-off-by: Stefan Beller > --- > > The non alignment of white space harmed my feelings for aesthetics more > than it should have. Hmm, but this does not align curlies for OPT_DATE(), OPT_EXPIRY_DATE(), etc... > > parse-options.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/parse-options.h b/parse-options.h > index c71e9da..08d7818 100644 > --- a/parse-options.h > +++ b/parse-options.h > @@ -126,7 +126,7 @@ struct option { > #define OPT_BOOL(s, l, v, h) OPT_SET_INT(s, l, v, h, 1) > #define OPT_HIDDEN_BOOL(s, l, v, h) { OPTION_SET_INT, (s), (l), (v), NULL, \ > (h), PARSE_OPT_NOARG | PARSE_OPT_HIDDEN, NULL, 1} > -#define OPT_CMDMODE(s, l, v, h, i) { OPTION_CMDMODE, (s), (l), (v), NULL, \ > +#define OPT_CMDMODE(s, l, v, h, i) { OPTION_CMDMODE, (s), (l), (v), NULL, \ > (h), PARSE_OPT_NOARG|PARSE_OPT_NONEG, NULL, (i) } > #define OPT_INTEGER(s, l, v, h) { OPTION_INTEGER, (s), (l), (v), N_("n"), (h) } > #define OPT_STRING(s, l, v, a, h) { OPTION_STRING, (s), (l), (v), (a), (h) }