From: Junio C Hamano Date: Wed, 12 Aug 2015 16:29:00 GMT Subject: Re: [PATCH v10 02/13] ref-filter: print output to strbuf for formatting Message-ID: In-Reply-To: Karthik Nayak writes: >>> + format_quote_value(atomv, quote_style, &output); >> >> If the one to add a literal string (with %hex escaping) is called "append_", >> then this should be called append_quoted_atom() or something, no? > > Although it does append like "append_non_atom" this is more of formatting based > on the quote given hence the name. Appending formatted values is still appending, no?