From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 03 Sep 2015 19:11:57 GMT
Subject: Re: [PATCH] Remove perl dependant commands if NO_PERL is set
Message-ID: <xmqq7fo7jp1e.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <1441298147-83601-1-git-send-email-garga@FreeBSD.org>

garga@FreeBSD.org writes:

> From: Renato Botelho <garga@FreeBSD.org>
>
> git-submodule and git-request-pull are written in sh but use perl
> internally. Add them to be replaced by unimplemented.sh when NO_PERL
> flag is set
> ---

Missing sign-off.

You also may want to hold off the "git-submodule" bit, as I expect
http://thread.gmane.org/gmane.comp.version-control.git/277128/focus=277129
would be one of the first changes to be in 'master' after the
upcoming release 2.6 (that is, it is likely that perl dependency
would be removed in 2.7).

>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index e326fa0..4dae0ec 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1795,7 +1795,7 @@ git-instaweb: git-instaweb.sh GIT-SCRIPT-DEFINES
>  	chmod +x $@+ && \
>  	mv $@+ $@
>  else # NO_PERL
> -$(SCRIPT_PERL_GEN) git-instaweb: % : unimplemented.sh
> +$(SCRIPT_PERL_GEN) git-instaweb git-submodule git-request-pull: % : unimplemented.sh
>  	$(QUIET_GEN)$(RM) $@ $@+ && \
>  	sed -e '1s|#!.*/sh|#!$(SHELL_PATH_SQ)|' \
>  	    -e 's|@@REASON@@|NO_PERL=$(NO_PERL)|g' \