From: Junio C Hamano Date: Fri, 04 Sep 2015 15:49:34 GMT Subject: Re: [PATCH] pack-protocol: document newline behavior in push commands Message-ID: In-Reply-To: <20150904090044.GB32751@sigill.intra.peff.net> Jeff King writes: > Right, it was the second "we know..." that made me worry. It is really > "we assume". :) Whether it is right according to the spec or not, the > real world is sometimes more complicated. And given that there is no > real advantage to changing the sending behavior now, I didn't think it > worth doing. Agreed. >>> This documentation update is good in that it makes the examples >> easier to read (by the way, the first pre-context line ends with >> '\n', which we would eventually also address) by making the reader >> understand that the convention used in this S:/C: exchange >> illustration the optional LF is not shown. > > In the second patch I left them all intact, but I agree that we could > drop the "\n" entirely from the example conversations, as it is implied > (and GIT_PACKET_TRACE, for example, does not even show it). Sure.