From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 20 Oct 2015 05:19:29 GMT
Subject: Re: [PATCH v3 10/34] mailinfo: move global "line" into mailinfo() function
Message-ID: <xmqq7fmi9kwu.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CAPig+cQ5bcaTEsGMP7_LZKD4ze8vQAaqcw7kbhU7rZQXGdDRUQ@mail.gmail.com>

Eric Sunshine <sunshine@sunshineco.com> writes:

> On Mon, Oct 19, 2015 at 3:28 AM, Junio C Hamano <gitster@pobox.com> wrote:
>> With the previous steps, it becomes clear that the mailinfo()
>> function is the only one that wants the "line" to be directly
>> touchable.  Move it to the function scope of this function.
>>
>> Signed-off-by: Junio C Hamano <gitster@pobox.com>
>> ---
>> diff --git a/builtin/mailinfo.c b/builtin/mailinfo.c
>> index 12d1eda..c8dc73f 100644
>> --- a/builtin/mailinfo.c
>> +++ b/builtin/mailinfo.c
>> @@ -12,7 +12,6 @@ static FILE *cmitmsg, *patchfile, *fin, *fout;
>>  static int keep_subject;
>>  static int keep_non_patch_brackets_in_subject;
>>  static const char *metainfo_charset;
>> -static struct strbuf line = STRBUF_INIT;
>>  static struct strbuf name = STRBUF_INIT;
>>  static struct strbuf email = STRBUF_INIT;
>>  static char *message_id;
>> @@ -966,6 +965,8 @@ static void handle_info(void)
>>  static int mailinfo(FILE *in, FILE *out, const char *msg, const char *patch)
>>  {
>>         int peek;
>> +       struct strbuf line = STRBUF_INIT;
>
> Does there need to be a corresponding strbuf_release(&line) at the end
> of the function?

Indeed.
Thanks.