From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 24 May 2016 18:16:36 GMT
Subject: Re: [Bug?] log -p -W showing the whole file for a patch that adds to the end?
Message-ID: <xmqq7fej5njv.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <5740AC28.6010202@web.de>

René Scharfe <l.s.r@web.de> writes:

>   diff: factor out match_func_rec()
>   diff: handle appended chunks better with -W
>   diff: ignore empty lines before added functions with -W
>   diff: don't include common trailing empty lines with -W
>   grep: don't extend context to trailing empty lines with -W
>
>  grep.c        | 28 ++++++++++++++++++++++++--
>  xdiff/xemit.c | 63 ++++++++++++++++++++++++++++++++++++++++++++++++++++-------
>  2 files changed, 82 insertions(+), 9 deletions(-)

Thanks.  The flow of reasoning in this cover letter was written very
well and I think I can agree with all of them.

It is curious that this much behaviour change does not need any
changes in the test scripts.  We do not have sufficient coverage,
perhaps?