From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 28 Apr 2017 00:15:27 GMT
Subject: Re: [PATCH v3 4/9] rebase -i: also expand/collapse the SHA-1s via the rebase--helper
Message-ID: <xmqq7f25mlpc.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <alpine.DEB.2.20.1704272331190.3480@virtualbox>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

>> > +	out = fopen(todo_file, "w");
>> 
>> The usual "open lockfile, write to it and then rename" dance is not
>> necessary for the purpose of preventing other people from reading
>> this file while we are writing to it.  But if we fail inside this
>> function before we fclose(3) "out", the user will lose the todo
>> list.  It probably is not a big deal, though.
>
> I guess you're right. It is bug-for-bug equivalent to the previous shell
> function, though.

I think the scripted version uses the "write to $todo.new and mv
$todo.new to $todo" pattern so you'd at least have something to go
back to when the loopfails.