From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 18 Oct 2018 02:35:08 GMT
Subject: Re: [PATCH 5/9] submodule.c: do not copy around submodule list
Message-ID: <xmqq7eigvv6r.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20181017214534.199890-1-jonathantanmy@google.com>

Jonathan Tan <jonathantanmy@google.com> writes:

>> By doing so we'll have access to the util pointer for longer that
>> contains the commits that we need to fetch, which will be
>> useful in a later patch.
>
> It seems that the main point of this patch is so that the OIDs be stored
> in changed_submodule_names, because you need them in a later patch. If
> so, I would have expected a commit title like "submodule: store OIDs in
> changed_submodule_names".
>
> ...
> This patch looks good, except that the commit title and message could
> perhaps be clearer.

Thanks for a thoughtful review; not just this step, but for your review
comments on all the other steps in the series are very helpful.