From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 10 Apr 2020 19:10:12 GMT
Subject: Re: [PATCH 2/5] ci/lib: allow running in GitHub Actions
Message-ID: <xmqq7dynjgx7.fsf@gitster.c.googlers.com>
In-Reply-To: <20200410153131.GM2224@szeder.dev>

SZEDER Gábor <szeder.dev@gmail.com> writes:

>> > CI_OS_NAME=osx.  This is head-scratchingly backwards, and I think
>> >
>> >   test "$CI_OS_NAME" = macos && CI_OS_NAME=osx
>> >
>> > would read better.
>> 
>> I can understand where you come from, but your code is not `set -e` safe,
>
> It works as expected in at least in dash, Bash, BusyBox sh, ksh,
> ksh93, mksh/lksh, yash, posh, FreeBSD /bin/sh, NetBSD /bin/sh.

Thanks for a clarification.  I do not use "set -e" myself (it is not
a good idea to rely on it in general), and was wondering if what was
said up there was true, as it did not sound like a useful behaviour
at all.  Not complaining about a non-zero exit before && or || makes
it usable ;-)