From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 23 Apr 2020 21:54:44 GMT
Subject: Re: Git 2.26 fetches many times more objects than it should, wasting gigabytes
Message-ID: <xmqq7dy5g95n.fsf@gitster.c.googlers.com>
In-Reply-To: <20200423213735.242662-1-jonathantanmy@google.com>

Jonathan Tan <jonathantanmy@google.com> writes:

> But in v2:
>
>   if (!haves_added || *in_vain >= MAX_IN_VAIN) {
>
> ("haves_added" is irrelevant to this discussion. It is another
> termination condition - when we have run out of "have"s to send.)
>
> So there is no check that "continue" was sent. We probably should change
> v2 to match v0.

That sounds like a good change.

Thanks.