From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 07 Jun 2022 17:32:53 GMT
Subject: Re: [PATCH 0/3] remote API: fix -fanalyzer-spotted freeing issue
Message-ID: <xmqq7d5sxttm.fsf@gitster.g>
In-Reply-To: <cover-0.3-00000000000-20220607T154520Z-avarab@gmail.com>

Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:

> This series is spun off from the recent RFC -fanalyzer series[1] and
> fixes a clear bug in remote_state_clear().

[1/3] is a pretty-much "Meh" (read: if it is already in the code, it
is not worth a patch noise to go and fix it, even though we would
avoid newly introducing the construct in new code), and some part of
[3/3] I am not so sure about (read: it is a mixed bag of changes),
but [2/3] is a bug that I find surprising that nobody noticed at
runtime.

Thanks.  Will queue.