From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 30 Aug 2022 21:36:33 GMT
Subject: Re: [PATCH v3 1/5] t3701: redefine what is "bogus" output of a diff filter
Message-ID: <xmqq7d2pifby.fsf@gitster.g>
In-Reply-To: <9261de42-3287-6ccb-6cf5-21c0a8ee1f17@gmail.com>

Phillip Wood <phillip.wood123@gmail.com> writes:

> The existing test deletes the first line of the diff[1] - so it is
> removing the "diff --git ..." header not the hunk header. This patch
> changes the filter to delete everything except the diff header which
> seems like a less realistic test.

Is it that all it cares about is that the output has the same number
of lines as the input?  If so, I agree that it is much less realistic,
but it may not matter in practice.  Even an "exit 0" might do ;-)

I may be quite off the mark on this one, though.