From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 01 May 2024 22:06:19 GMT
Subject: Re: [PATCH v5 2/7] files-backend: extract out `create_symref_lock()`
Message-ID: <xmqq7cgdjig4.fsf@gitster.g>
In-Reply-To: <20240501202229.2695774-3-knayak@gitlab.com>

Karthik Nayak <karthik.188@gmail.com> writes:

> +	if (!fdopen_lock_file(&lock->lk, "w"))
> +		return error("unable to fdopen %s: %s",
> +			     get_lock_file_path(&lock->lk), strerror(errno));
> +
> +	if (fprintf(get_lock_file_fp(&lock->lk), "ref: %s\n", target) < 0)
> +		return error("unable to fprintf %s: %s",
> +			     get_lock_file_path(&lock->lk), strerror(errno));

error() is end-user facing, so "fprintf" is probably a bit too
precise?  "fprintf" -> "write to"

Also we may want to make them (not just this new message but other
error() messages in related code paths) localizable but that is
probably beyond the scope of this topic.