From: Junio C Hamano Date: Tue, 16 Jun 2026 14:25:02 GMT Subject: Re: [PATCH v3] read_gitfile(): simplify NOT_A_REPO error message Message-ID: In-Reply-To: <20260616123516.GA2301231@coredump.intra.peff.net> Jeff King writes: > On Tue, Jun 16, 2026 at 07:19:20AM -0400, Jeff King wrote: > >> Here it is. Thanks. > +@@ t/t7450-bad-git-dotfiles.sh: test_expect_success 'git dirs of sibling submodules must not be nested' ' > + test_expect_success 'submodule git dir nesting detection must work with parallel cloning' ' > + test_must_fail git clone --recurse-submodules --jobs=2 nested clone_parallel 2>err && > + cat err && > +- grep -E "(already exists|is inside git dir|not a git repository)" err && > ++ grep -E "(already exists|is inside git dir|does not point to a valid repository)" err && A few things. * Will we be happy to see only one of these possibilities, or do we expect to see these once for each kind? * a recently started in-flight topic tries to catch bare "grep" and fails until you write test_grep X-<. > We also racily trigger this in t7450. During parallel cloning we might > see one of several errors, including this one. And so we must update > that message, too (you can otherwise find the failure pretty quickly by > running t7450 with --stress).