From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 07 Sep 2026 20:58:00 GMT
Subject: Re: [PATCH v7 4/4] hook: introduce the receive-report hook
Message-ID: <xmqq7bkw3hk7.fsf@gitster.g>
In-Reply-To: <20260904-758-introduce-hook-v7-4-6c66f0a3a572@gmail.com>

Karthik Nayak <karthik.188@gmail.com> writes:

> @@ -2469,6 +2510,12 @@ static void report(struct command *commands, const struct strbuf *unpack_status,
>  
>  	generate_report(&buf, commands, unpack_status, version);
>  
> +	if (run_receive_report_hook(&buf)) {
> +		strbuf_reset(&buf);
> +		override_cmds_error(commands, "receive-report hook failed");
> +		generate_report(&buf, commands, unpack_status, false);
> +	}

Hmph, what does 'false' mean here?  Didn't you mean to use the same
"version" like you used in the previous call in the preimage?