From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 12 Sep 2013 22:26:10 GMT
Subject: Re: [PATCH v2] urlmatch.c: recompute ptr after append_normalized_escapes
Message-ID: <xmqq61u5oewt.fsf@gitster.dls.corp.google.com>
In-Reply-To: <20130912220505.GM4326@google.com>

Jonathan Nieder <jrnieder@gmail.com> writes:

> Kyle J. McKay wrote:
>
>> The longer comment looks good to me.  If you think the code will be safe from
>> simplification patches without a comment, that works for me too.
>
> I think if we can't trust reviewers to catch this kind of thing, we're
> in trouble (i.e., moving too fast). :)
>
> So FWIW my instinct is to leave the comment out, since I actually find
> it more readable that way (otherwise I would wonder, "Why am I being
> told that a strbuf's buffer has a nonconstant address?  Do some other
> strbufs have a constant address or something?")

Yeah, I was staring at that message and coming to the same
conclusion.