From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 30 Oct 2013 17:36:29 GMT
Subject: Re: [PATCH 20/19] count-objects: consider .bitmap without .pack/.idx pair garbage
Message-ID: <xmqq61sed5k2.fsf@gitster.dls.corp.google.com>
In-Reply-To: <20131030065922.GC11317@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> On Sat, Oct 26, 2013 at 05:19:56PM +0700, Nguyen Thai Ngoc Duy wrote:
>
>>  Maybe squash this in some place, or leave it separate. I'm fine either way.
>
> Thanks, this makes sense.  I've left it as a separate commit.
>
> Your subject did not quite make sense to me, as the effect is to _not_
> report .bitmap files as garbage. I updated the commit message to this:
>
>     count-objects: recognize .bitmap in garbage-checking
>     
>     Count-objects will report any "garbage" files in the packs
>     directory, including files whose extensions it does not
>     know (case 1), and files whose matching ".pack" file is
>     missing (case 2).  Without having learned about ".bitmap"
>     files, the current code reports all such files as garbage
>     (case 1), even if their pack exists. Instead, they should be
>     treated as case 2.

Thanks; that reads well.