From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 04 Feb 2014 00:00:09 GMT
Subject: Re: [PATCH 7/8] combine-diff: Fast changed-to-all-parents paths scanning
Message-ID: <xmqq61ovbvcm.fsf@gitster.dls.corp.google.com>
In-Reply-To: <c0ad49d850377aedffa0a593fef8738112019b01.1391430523.git.kirr@mns.spb.ru>

Kirill Smelkov <kirr@mns.spb.ru> writes:

> +	parents_sha1 = xmalloc(nparent * sizeof(parents_sha1[0]));
> +	for (i = 0; i < nparent; i++)
> +		parents_sha1[i] = parents->sha1[i];
> +
> +	/* fake list head, so worker can assume it is non-NULL */
> +	struct combine_diff_path paths_head;

decl-after-statement; please fix.

> +	paths_head.next = NULL;
> +
> +	struct strbuf base;

likewise.