From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 24 Mar 2015 15:58:38 GMT
Subject: Re: [PATCH 00/14] numparse module: systematically tighten up integer parsing
Message-ID: <xmqq619q8k0h.fsf@gitster.dls.corp.google.com>
In-Reply-To: <551185D9.6050200@alum.mit.edu>

Michael Haggerty <mhagger@alum.mit.edu> writes:

> It is easy to allow "--abbrev=+7"; I would just need to add NUM_PLUS to
> those call sites. Should I do so?

The more relevant question to ask from my point of view is why you
need to "add" NUM_PLUS to "enable" it.  What valid reason do you
have to forbid it anywhere?  Only because you do not accept it by
default, you need to "add" to "enable".

>> Why is it a problem to allow "git cmd --hexval=0x1234", even if "git
>> cmd --hexval=1234" would suffice?
>
> In some cases we would like to allow that flexibility; in some cases
> not. But the strtol()/strtoul() functions *always* allow it.

The same issue.  Whare are these "some cases"?