From: Junio C Hamano Date: Fri, 08 May 2015 20:25:45 GMT Subject: Re: [PATCH 2/3] sha1_name: get_sha1_with_context learns to follow symlinks Message-ID: In-Reply-To: Perhaps something like the attached patch is a good idea (I used "BUG:" for now), I wonder? Documentation/CodingGuidelines | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/Documentation/CodingGuidelines b/Documentation/CodingGuidelines index c6e536f..020370e 100644 --- a/Documentation/CodingGuidelines +++ b/Documentation/CodingGuidelines @@ -232,7 +232,12 @@ For C programs: to be translated, that follows immediately after it */ _("Here is a translatable string explained by the above."); + - Speaking of translations, do not mark the message to die() that + should never trigger unless there is an programming error. E.g. + + die("BUG: frotz() called with NULL pointer to xyzzy parameter"); + - - Double negation is often harder to understand than no negation + - Double negation is not easier to understand than no negation at all. - There are two schools of thought when it comes to comparison,