From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 12 Jun 2015 21:01:29 GMT
Subject: Re: [PATCH/RFC] upload-pack: Fail if cloning empty namespace
Message-ID: <xmqq616sd4k6.fsf@gitster.dls.corp.google.com>
In-Reply-To: <1434140115-3139-1-git-send-email-johannes@kyriasis.com>

Johannes Löthberg <johannes@kyriasis.com> writes:

> +	if (get_git_namespace() && !symref.items) {
> +		die("git upload-pack: tried to clone from empty namespace");
> +	}

Is this sufficient?

get_git_namespace() returns environment.c::namespace, which is set
up in setup_git_env() by calling expand_namespace() and strlen()
is run on that value, so I would presume the function will *ALWAYS*
return true.  Even when not namespaced, you would get an empty
string "" whose address is not NULL, no?