From: Junio C Hamano <gitster@pobox.com>
Date: Sat, 17 Oct 2015 21:24:13 GMT
Subject: Re: [PATCH v2 2/4] stripspace: Use parse-options for command-line parsing
Message-ID: <xmqq6125choi.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20151017103134.GD2468@distanz.ch>

Tobias Klauser <tklauser@distanz.ch> writes:

> On 2015-10-16 at 19:29:35 +0200, Junio C Hamano <gitster@pobox.com> wrote:
>> Junio C Hamano <gitster@pobox.com> writes:
>> 
>> >> -	if (mode == INVAL)
>> >> -		usage(usage_msg);
>> >
>> > When given "git stripspace -s blorg", we used to set mode to INVAL
>> > and then showed the correct usage.  But we no longer have a check
>> > that corresponds to the old INVAL thing, do we?  Perhaps check argc
>> > to detect presence of an otherwise ignored non-option argument
>> > immediately after parse_options() returns?
>> 
>> Perhaps like this.
>
> Thanks. I'll fold it into v3.

Before starting v3, please fetch from me and check what is queued on
'pu'.  It may turn out that the fix-ups I did while queuing this
round is sufficient, in which case you can just say that instead ;-)

Thanks.