From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 02 Feb 2016 03:10:04 GMT
Subject: Re: parse_object does check_sha1_signature but not parse_object_buffer?
Message-ID: <xmqq60y7u7sj.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20160202015701.GA30444@glandium.org>

Mike Hommey <mh@glandium.org> writes:

> Shouldn't parse_object_buffer also do check_sha1_signature?

In general, it shouldn't; its callers are supposed to do it as
additional check when/if needed.  Callers like the one in fsck.c
does not want to die after seeing one bad one.  We want to report
and keep checking other things.