From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 03 May 2016 20:02:08 GMT
Subject: Re: [PATCH v2 14/41] builtin/worktree.c: use error_errno()
Message-ID: <xmqq60uunc5b.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <1462277054-5943-15-git-send-email-pclouds@gmail.com>

Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:

> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
> ---
>  builtin/worktree.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/builtin/worktree.c b/builtin/worktree.c
> index d8e3795..331ecf6 100644
> --- a/builtin/worktree.c
> +++ b/builtin/worktree.c
> @@ -110,7 +110,7 @@ static void prune_worktrees(void)
>  		if (ret < 0 && errno == ENOTDIR)
>  			ret = unlink(path.buf);
>  		if (ret)
> -			error(_("failed to remove: %s"), strerror(errno));
> +			error_errno(_("failed to remove '%s'"), path.buf);

This also deserves a mention in the log message.  We didn't say what
we failed to remove, now we do, which is an improvement.