From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 20 May 2016 16:52:21 GMT
Subject: Re: [PATCH v2] upload-pack.c: use of parse-options API
Message-ID: <xmqq60u8fz96.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <1446970271.10941827.1463727190993.JavaMail.zimbra@imag.fr>

Matthieu Moy <matthieu.moy@grenoble-inp.fr> writes:

>> Using "format-patch --patience" or some other diff option, and pick
>> the best one to give to "send-email" would indeed be a way to do so.
>
> It's a matter of taste. My flow is "send-email-only", I do as much as
> possible in-tree, and when I notice something to do during "git send-email",
> I just abort and retry. So "Oops, looks ugly, I'll try with another
> option" is OK in this flow.

Ah, I didn't consider "final-review in send-email and aborting".

I agree that it is just the matter of preference, if it is easy to
review everything that you would be sending out, and decide to
abort.  I just thought that final review would be cumbersome in that
flow.