From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 06 Jul 2016 21:11:24 GMT
Subject: Re: [PATCH v4] Refactor recv_sideband()
Message-ID: <xmqq60sisc8z.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <alpine.LFD.2.20.1607051625581.1824@knanqh.ubzr>

Nicolas Pitre <nico@fluxnic.net> writes:

> Here's a patch on top of it providing small optimizations.

Thanks; will apply with a miniscule fix.

> ----- >8
> Subject: sideband.c: small optimization of strbuf usage
>
> Signed-off-by: Nicolas Pitre <nico@fluxnic.net>
> ...
> @@ -97,7 +97,7 @@ int recv_sideband(const char *me, int in_stream, int out)
>  	}
>  
>  	if (outbuf.len) {
> -		strbuf_addf(&outbuf, "\n");
> +		strbuf_addch(&outbuf, "\n");

'\n', or "\n"[0] ;-)

>  		xwrite(2, outbuf.buf, outbuf.len);
>  	}
>  	strbuf_release(&outbuf);