From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 12 Jul 2016 20:38:28 GMT
Subject: Re: [PATCH 0/5] Number truncation with 4+ GB files on 32-bit systems
Message-ID: <xmqq60sa4mnv.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20160705170558.10906-1-pclouds@gmail.com>

Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:

> Since I now could reproduce the problem that Christoph showed, I
> decided to send the good patches out. To sum up, we use "unsigned
> long" in some places related to file size. On 32-bit systems, it's
> limited to 32 bits even though the system can handle files larger than
> that (off_t is 64-bit). This fixes it.
>
> clang -Wshorten-64-to-32 is very helpful to spot these problems. I
> have a couple more patches to clean all these warnings, but some need
> more code study to see what is the right way to do.
>
> Most of the rest seems harmless, except for the local variable "size"
> in builtin/pack-objects.c:write_one(). I might send 6/5 for that one.

With 1-7/5 it appears t1050 is broken?