From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 23 Aug 2016 21:45:24 GMT
Subject: Re: [PATCH 1/7] cache_or_unpack_entry: drop keep_cache parameter
Message-ID: <xmqq60qrupl7.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20160822215744.nc3yqv64gf3hwcv4@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> There is only one caller of cache_or_unpack_entry() and it
> always passes 1 for the keep_cache parameter. We can
> simplify it by dropping the "!keep_cache" case.
>
> Another call, which did pass 0, was dropped in abe601b
> (sha1_file: remove recursion in unpack_entry, 2013-03-27),
> as unpack_entry() now does more complicated things than a
> simple unpack when there is a cache miss.
>
> Signed-off-by: Jeff King <peff@peff.net>
> ---
>  sha1_file.c | 13 +++----------
>  1 file changed, 3 insertions(+), 10 deletions(-)

Makes sense.  Thanks.