From: Junio C Hamano Date: Wed, 24 Aug 2016 17:59:54 GMT Subject: Re: [PATCH 3/7] release_delta_base_cache: reuse existing detach function Message-ID: In-Reply-To: <20160824174122.372c7pi4ub5bxcat@sigill.intra.peff.net> Jeff King writes: > That is not too bad, I guess. I can switch it if you prefer that way. > Since there are only these two callers with two different sets of needs > (and the function is static), I just let them continue inspecting the > elements directly. I do not think it is too hard to refactor later when need arises; it is not like we have too many callers and this is a file-scope static helper to begin with.