From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 18 Nov 2016 21:37:46 GMT
Subject: Re: [PATCH v4 3/6] grep: add submodules as a grep source type
Message-ID: <xmqq60nkmpud.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <1479499135-64269-4-git-send-email-bmwill@google.com>

Brandon Williams <bmwill@google.com> writes:

> diff --git a/grep.h b/grep.h
> index 5856a23..267534c 100644
> --- a/grep.h
> +++ b/grep.h
> @@ -161,6 +161,7 @@ struct grep_source {
>  		GREP_SOURCE_SHA1,
>  		GREP_SOURCE_FILE,
>  		GREP_SOURCE_BUF,
> +		GREP_SOURCE_SUBMODULE,
>  	} type;
>  	void *identifier;

Hmph, interesting.  We have avoided ending enum definition with a
comma, because it is only valid in more recent C than what we aim to
support.  This patch is not introducing a new problem, but just
doing the same thing that would have broken older compilers as the
existing code.  Perhaps those older compilers have died out?