From: Junio C Hamano Date: Wed, 10 May 2017 05:55:50 GMT Subject: Re: [PATCH 5/8] pathspec: convert strip_submodule_slash to take an index Message-ID: In-Reply-To: <20170509191805.176266-6-bmwill@google.com> Brandon Williams writes: > Signed-off-by: Brandon Williams > --- > pathspec.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) This conversion is not wrong per-se, but I wonder if there is a practical situation where we want to validate a pathspec element against an in-core index that does not represent the index currently in effect (aka "the_index"). I do not think of any offhand myself.