From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 17 Oct 2017 20:55:18 GMT
Subject: Re: [PATCH 3/3] check-ref-format doc: --branch validates and expands <branch>
Message-ID: <xmqq60bdo5op.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20171017071234.m6j4rqn6izdvla6d@aiede.mtv.corp.google.com>

Jonathan Nieder <jrnieder@gmail.com> writes:

> From: Junio C Hamano <gitster@pobox.com>
>
> "git check-ref-format --branch $name" feature was originally
> introduced (and was advertised) as a way for scripts to take any
> end-user supplied string (like "master", "@{-1}" etc.) and see if it
> is usable when Git expects to see a branch name, and also obtain the
> concrete branch name that the at-mark magic expands to.
>
> Emphasize that "see if it is usable" role in the description and
> clarify that the @{...} expansion only occurs when run from within a
> repository.
>
> [jn: split out from a larger patch]
>
> Helped-by: Jeff King <peff@peff.net>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
> ---

Missing sign-off, unlike the other two, intended?

I'll take these three to replace what I tentatively queued, not
necessarily because I like the change in 1/3 better, but because
these are explained much better; besides I prefer a version that at
least two people deeply looked at.

Thanks.