From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 15 Mar 2018 15:55:07 GMT
Subject: Re: [PATCH] filter-branch: return 2 when nothing to rewrite
Message-ID: <xmqq605x72qs.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180315154815.GA29874@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> Hrm. I took the goal to mean that we used to exit with a failing "1" in
> this case, and now we would switch to a more-specific "2". And I think
> that matches the behavior of the patch:
>
> -test $commits -eq 0 && die "Found nothing to rewrite"
> +test $commits -eq 0 && die_with_status 2 "Found nothing to rewrite"
>
> Am I missing something?

No, other than that I wrote my response before sufficiently
caffeinated ;-)

Thanks, then other than the lack of doc updates, I do not see an
issue.