From: Junio C Hamano <gitster@pobox.com>
Date: Sat, 24 Nov 2018 02:27:34 GMT
Subject: Re: [PATCH v1 2/2] log -S: Add test which searches in binary files
Message-ID: <xmqq5zwn43c9.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <87lg5lzd7i.fsf@evledraar.gmail.com>

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

> On Wed, Nov 21 2018, Thomas Braun wrote:
>
>> The -S <regex> option of log looks for differences that changes the
>> number of occurrences of the specified string (i.e. addition/deletion)
>> in a file.
>>
> ...
> This should just be part of 1/2 since the behavior is changed there &
> the commit message should describe both cases.

Sensible suggestion.  Thanks.