From: Junio C Hamano Date: Fri, 08 Mar 2019 01:37:08 GMT Subject: Re: [PATCH 0/2] stash: handle pathspec magic again Message-ID: In-Reply-To: "Johannes Schindelin via GitGitGadget" writes: > It was reported in https://github.com/git-for-windows/git/issues/2037 that > git stash -- ':(glob)**/*.testextension is broken. The problem is not even > the stash operation itself, it happens when the git add part of dropping the > local changes is spawned: we simply passed the parsed pathspec instead of > the unparsed one. > > While verifying the fix, I also realized that the escape hatch was seriously > broken by my "backport of the -q option": It introduced four bogus eval > statements, which really need to be dropped. Thanks. We seem to be piling many "oops" on top, even after the topic hits 'next'. But fixes are better late than never ;-). Will queue.