From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 06 Aug 2019 16:48:00 GMT
Subject: Re: [RFC PATCH v3 0/3] grep: no leaks or crashes (windows testing needed)
Message-ID: <xmqq5znakzpb.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20190806163658.66932-1-carenas@gmail.com>

Carlo Marcelo Arenas Belón  <carenas@gmail.com> writes:

> Junio, could you comment in my assumption that the use of grep in
> revision.c doesn't require initializing a PCRE2 global context and
> therefore not doing the cleanup?

Many callers of setup_revisions() do so only to run two-thing diffs
(e.g. run_diff_files() that compares the index and the working tree),
but some do so to traverse the history with the grep_filter
(e.g. "git log --grep=<pattern>").  "git log -P" may affect how that
pattern is used to match the contents of the log messages, no?