From: Junio C Hamano Date: Thu, 02 Sep 2021 20:53:59 GMT Subject: Re: [PATCH 0/9] remove dead shell code Message-ID: In-Reply-To: Ævar Arnfjörð Bjarmason writes: > Remove dead shell code in git-sh-setup, inspired by parallel > discussion on another topic (but the two don't conflict): > https://lore.kernel.org/git/87lf4f9gre.fsf@evledraar.gmail.com/ > > The last two patches were picked from a dropped series of mine > submitted earlier this year, it was dropped because of other more > complex patches that I haven't included here: > https://lore.kernel.org/git/20210311001447.28254-1-avarab@gmail.com/ > > Ævar Arnfjörð Bjarmason (9): > git-sh-setup: remove unused set_reflog_action() function > git-sh-setup: remove unused git_editor() function > git-sh-setup: remove unused git_pager() function > git-sh-setup: remove unused sane_egrep() function > git-sh-setup: remove unused require_work_tree_exists() function > git-sh-setup: move create_virtual_base() to mergetools/p4merge > git-sh-setup: move peel_committish() function to git-subtree.sh > git-bisect: remove unused SHA-1 $x40 shell variable > test-lib: remove unused $_x40 and $_z40 variables Was "unused" above decided based solely on the presence of in-tree users? If that is the case, I do not think we want to take these sh-setup changes. The implementation details of the remaining part of git-bisect.sh and test-lib.sh are OK, of course, as that is truly our local issue. Thanks.