From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 02 Mar 2022 23:20:51 GMT
Subject: Re: [PATCH 12/15] gettext tests: don't ignore "test-tool regex" exit code
Message-ID: <xmqq5yowgcvg.fsf@gitster.g>
In-Reply-To: <patch-12.15-f3cc5bc7eb9-20220302T171755Z-avarab@gmail.com>

Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:

> -test_have_prereq GETTEXT_LOCALE &&
> -test-tool regex "HALLÓ" "Halló" ICASE &&
> -test_set_prereq REGEX_LOCALE
> +test_expect_success GETTEXT_LOCALE 'setup REGEX_LOCALE prerequisite' '
> +	if test-tool regex "HALLÓ" "Halló" ICASE
> +	then
> +		test_set_prereq REGEX_LOCALE

This looks sensible but

> +	else
> +		test_must_fail test-tool regex "HALLÓ" "Halló" ICASE

this side looks puzzling.  I think this way to avoid counting abort
etc as passing "must fail" test would be the least bad that we can
do.

Nicely done.



> +	fi
> +'