From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 10 May 2023 22:32:24 GMT
Subject: Re: [PATCH] merge-tree: load default git config
Message-ID: <xmqq5y8z3jif.fsf@gitster.g>
In-Reply-To: <pull.1530.git.1683745654800.gitgitgadget@gmail.com>

"Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com> writes:

> The fix is simple: load the default Git config in cmd_merge_tree().
> This may also fix other behaviors that are effected by reading default
> config. The only possible downside is a little extra computation time
> spent reading config. The config parsing is placed after basic argument
> parsing so it does not slow down usage errors.

Presumably merge-tree wants to serve a low-level machinery that
gives reliable reproducible result, we may want to keep the
configuration variables we read as narrow as practical.  The
default_config() callback may still be wider than desirable from
that point of view, but I guess that is the most reasonable choice?

Thanks.