From: Junio C Hamano Date: Tue, 09 Jan 2024 17:12:01 GMT Subject: Re: [Outreachy][PATCH v4] Port helper/test-ctype.c to unit-tests/t-ctype.c Message-ID: In-Reply-To: <33c81610-0958-49da-b702-ba8d96ecf1d3@gmail.com> Phillip Wood writes: > In the new version we only test the characters 0-255, not EOF. If > there is a good reason for removing the EOF tests then it should be > explained in the commit message. If not it would be good to add those > tests back. Thanks for sharp eyes. Didn't notice the handling of EOF myself.