From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 09 Jan 2024 17:50:04 GMT
Subject: Re: [PATCH v2 1/2] t7501: add tests for --include, --only of commit
Message-ID: <xmqq5y02iegj.fsf@gitster.g>
In-Reply-To: <20240109165304.8027-4-shyamthakkar001@gmail.com>

Ghanshyam Thakkar <shyamthakkar001@gmail.com> writes:

> This commit adds tests for testing --include (-o) and --only (-o). It

"-i" not "-o" stands for "--include".

Please write in imperative mood.

> +test_expect_success '--include fails with untracked files' '
> +	echo content >baz &&
> +	test_must_fail git commit --include baz -m initial
> +'

My comment on argument order applies to this iteration, too.  Please
write your code to help readers.

> +test_expect_success 'commit --include' '
> +	test_when_finished "rm -rf remaining" &&

Why recursive removal when you _know_ what you create is a plan
file?