From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 17 Jul 2024 22:53:47 GMT
Subject: Re: [PATCH] sparse: ignore warning from new glibc headers
Message-ID: <xmqq5xt33a10.fsf@gitster.g>
In-Reply-To: <0e2c66ce-d870-4a03-a26e-a928183b9b2b@ramsayjones.plus.com>

Ramsay Jones <ramsay@ramsayjones.plus.com> writes:

> On 17/07/2024 20:20, Ramsay Jones wrote:
> [snip]
>
>> (SP_EXTRA_FLAGS didn't exist then)
> This is absolute rubbish, of course! ;)
>
> I don't know what I was thinking, but I suspect I was thinking about
> the recent _APPEND variables - except they were only for CFLAGS and
> LDFLAGS! Ho Hum.
>
> Sorry about that.

That's OK.  So in short, with a separate SP_EXTRA_FLAGS with "-Wno-vla",
Luc's patch is a sufficient fix without any downsides, no?