From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 26 Feb 2026 15:34:13 GMT
Subject: Re: [PATCH v7 00/10] fsmonitor: implement filesystem change listener for Linux
Message-ID: <xmqq5x7j5xje.fsf@gitster.g>
In-Reply-To: <pull.2147.v7.git.git.1772065643.gitgitgadget@gmail.com>

"Paul Tarjan via GitGitGadget" <gitgitgadget@gmail.com> writes:

> Changes since v6:
>
>  * Introduced FSMONITOR_OS_SETTINGS build variable (set to "unix" for macOS
>    and Linux, "win32" for Windows) to eliminate if/else conditionals in
>    Makefile, meson.build, and CMakeLists.txt per Junio's review
>  * Moved fsm-path-utils from FSMONITOR_OS_SETTINGS to
>    FSMONITOR_DAEMON_BACKEND since path-utils files are platform-specific
>  * Removed V9FS_MAGIC from remote filesystem detection (9p is used for local
>    VM/container host mounts where fsmonitor works fine)
>  * Removed redundant #include <libgen.h> (already provided by
>    compat/posix.h)
>  * Fixed cookie wait comment wording ("see" → "observe")
>  * Rewrote commit messages for IPC and settings dedup patches

I saw nothing unexpected in this iteration relative to the previous
one.  Looking good.

It would be nice to have another set of eyes on the inotify part of
this series before we mark it for 'next'.

Thanks.