From: Junio C Hamano Date: Wed, 26 Aug 2026 19:56:42 GMT Subject: Re: [PATCH v3 0/3] environment: clean up repository config handling Message-ID: In-Reply-To: Patrick Steinhardt writes: > On Fri, Aug 07, 2026 at 02:11:08PM -0700, Junio C Hamano wrote: >> Patrick Steinhardt writes: >> >> > On Fri, Aug 07, 2026 at 04:59:29PM +0800, Tian Yuchen wrote: >> >> Hi all, >> >> >> >> This series contains several cleanup patches for repository configuration >> >> handling. >> >> >> >> No functional changes are intended. The patches make the related code >> >> more consistent and easier to maintain by improving documentation, >> >> formatting, and the organization of repo_config_values. >> >> >> >> RFC: >> >> If there are other small cleanups in this area that would be useful to >> >> include, suggestions are welcome. >> > >> > Somewhat unrelated to this patch series, but I was wondering whether you >> > plan to drop the limitation in `repo_config_values()` that requires that >> > the passed-in repository is `the_repository`. This limitation is >> > starting to create problems as more and more of our infrastructure is >> > migrating into `struct repo_config_values`, so using a different repo >> > than `the_repository` is starting to become harder and harder in our >> > codebase. >> > >> > Thanks! >> > >> > Patrick >> >> Hmph, that is an interesting point. What is our plan to really >> ... > Yeah, this split is adding to the confusion indeed. I think that we > should make it a goal to unify those going forward. > ... > The last part about not modifying that structure could be quite a bit > painful though, as it would mean that we might have to adapt call chains > to pass down a `struct git_config_values` instead of a `struct > repository`. But arguably, that's the right thing to do anyway for at > least some subsystems that are independent of repositories. > > As you say though, none of this is really related to this patch series > at hand, and I don't think we need to resolve this discussion before we > can merge it. I just want to make sure that we have a plan for how to > get rid of `the_repository` instead of only shuffling stuff around. Well, after this sort-of offtopic exchange, the thread went dark. Is anybody interested in reviewing these patches and move the topic forward? Thanks.