From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 03 Sep 2013 17:33:47 GMT
Subject: Re: [PATCH 3/4] t: rev-parse-parents: avoid yoda conditions
Message-ID: <xmqq4na1u7wk.fsf@gitster.dls.corp.google.com>
In-Reply-To: <xmqq8uzdu817.fsf@gitster.dls.corp.google.com>

Junio C Hamano <gitster@pobox.com> writes:

> Felipe Contreras <felipe.contreras@gmail.com> writes:
>
>> There are two ways to fix an inconsistency, the other way is to fix
>> test_cmp. But that would be a change, and change is not welcome in
>> Git.
>
> If you want to do "test_cmp $actual $expect", you would have to
> first "fix" people's expectation that "diff A B" produces a change
> necessary to bring A to B, which would not likely to happen.  We do
> the 'test_cmp expect actual' for a reason.

By the way, I found the other changes (especially the last one) very
sensible.