From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 17 Dec 2013 22:09:19 GMT
Subject: Re: [PATCH v4 2/3] diff: Let "git diff -O" read orderfile from any file, fail properly
Message-ID: <xmqq4n67m8og.fsf@gitster.dls.corp.google.com>
In-Reply-To: <CALWbr2zXNF-aJHHnBnW1q1yaCmWt-rmMWypBWFanTBAK1pMWiQ@mail.gmail.com>

Antoine Pelisse <apelisse@gmail.com> writes:

>> How about not doing a fifo?
>
> That would certainly defeat the purpose of the test, which is to test
> against a fifo :-)

My point was that I did not see much value in reading the orderfile
data from anything but a file.  At that point, you are not testing
the "diff -O" orderfile option, but if strbuf_readline() reads from
a non-regular file.