From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 21 Jan 2014 22:50:52 GMT
Subject: Re: [PATCH v2 04/16] trailer: process command line trailer arguments
Message-ID: <xmqq4n4xt0dv.fsf@gitster.dls.corp.google.com>
In-Reply-To: <xmqqd2jlt0ua.fsf@gitster.dls.corp.google.com>

Junio C Hamano <gitster@pobox.com> writes:

>> +static struct trailer_item *create_trailer_item(const char *string)
>> +{
>> +	struct strbuf tok = STRBUF_INIT;
>> +	struct strbuf val = STRBUF_INIT;
>> +	struct trailer_item *new;
>> +
>> +	parse_trailer(&tok, &val, string);
>> +
>> +	int tok_alnum_len = alnum_len(tok.buf, tok.len);
>
> decl-after-stmt.
>
>> +
>> +	/* Lookup if the token matches something in the config */
>> +	struct trailer_item *item;

ditto.

>> +	for (item = first_conf_item; item; item = item->next)
>> +	{

Style.

I wonder if Cc list is being a bit too wide for this series, by the
way.